Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3.4.0 #100

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Add support for Ruby 3.4.0 #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f62f97e
Ruby 3.4 replaces initial backtick by single quote
voxik Nov 1, 2024
8667bd3
Support versions are now Ruby 3 and latest version of RSpec
JonRowe Nov 3, 2024
1722532
Port cucumber fix across from rspec-core
JonRowe Nov 3, 2024
38955ea
Merge pull request #96 from voxik/ruby34
JonRowe Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
strategy:
matrix:
ruby:
- '3.4'
- '3.3'
- '3.2'
- '3.1'
Expand Down
2 changes: 1 addition & 1 deletion features/its.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ Feature: attribute of subject
When I run rspec
Then the example should fail
And the output should contain "Failure/Error: its(:foo) { will_not raise_error }"
And the output should contain "expected no Exception, got #<NoMethodError: undefined method `foo'"
And the output should match /expected no Exception, got #<NoMethodError: undefined method [`']foo'/

Scenario: examples will warn when using non block expectations
Given a file named "example_spec.rb" with:
Expand Down
4 changes: 4 additions & 0 deletions script/test_all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ if ruby -e "exit(defined?(RUBY_PLATFORM) && RUBY_PLATFORM == 'java')"; then
# This is JRUBY which requires this one weird path trick...
PATH="${PWD}/bin:$PATH" \
bundle exec cucumber --strict
elif ruby -e "exit(RUBY_VERSION.to_f >= 3.4)"; then
# This is a monkey patch to fix an issue with cucumber using outdated hash syntax, remove when cucumber is updated or ruby 3.4 released
sed -i '$i\class Hash; alias :__initialize :initialize; def initialize(*args, **_kw, &block) = __initialize(*args, &block); end' bin/cucumber
bin/cucumber --strict
else
bundle exec cucumber --strict
fi;
Loading