updates username length to align with the spec (uint8 vs uint16) #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freelancer1845
force-pushed
the
1.0.x
branch
2 times, most recently
from
1a1e41e to
cb79bf6
Compare
OlegDokuka
requested changes
Oct 1, 2020
There was a problem hiding this comment.
@freelancer1845 can you please make sure that you modify only the username length related things and do not touch the rest of the things. It simplifies porting that commit to master then (since in master we have already done the migration from the deprecated classes and removed them completely)
rsocket-core/src/main/java/io/rsocket/metadata/AuthMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/AuthMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
This now follows the new specification. Test were also moved away from ...Fylweigth to ...Codec Signed-off-by: Jascha Riedel <[email protected]>
OlegDokuka
changed the title
|
Thank you @freelancer1845 for this contribution! Keep doing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now reads/writes username length as uint16.
The spec was changed in this commit:
rsocket/rsocket@2687daa
I also moved the code of AuthMetdataFlyweightTest to AuthMetadataCodecTest.