Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes deprecations dedicated for 1.1 #906

Merged
merged 1 commit into from
Aug 6, 2020
Merged

removes deprecations dedicated for 1.1 #906

merged 1 commit into from
Aug 6, 2020

Conversation

OlegDokuka
Copy link
Member

Removes all classes deprecated in 1.0 RC phase or a little later

Signed-off-by: Oleh Dokuka [email protected]

@OlegDokuka OlegDokuka added breaking changes Changes that break API or behaviour task for user attention labels Aug 3, 2020
@OlegDokuka OlegDokuka added this to the 1.1 M1 milestone Aug 3, 2020
@OlegDokuka OlegDokuka force-pushed the task/removes-1-1-derprecations branch from cec89a4 to 4a9baaf Compare August 3, 2020 19:12
rstoyanchev
rstoyanchev requested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and no more package cycles out of the box.

JMH benchmark needs an update too, e.g. it's using AbstractRSocket.

@OlegDokuka OlegDokuka force-pushed the task/removes-1-1-derprecations branch 2 times, most recently from f74a8d3 to 8e8800c Compare August 6, 2020 06:03
@OlegDokuka OlegDokuka force-pushed the task/removes-1-1-derprecations branch from 8e8800c to e04ce33 Compare August 6, 2020 08:06
@OlegDokuka OlegDokuka merged commit 6daa2eb into master Aug 6, 2020
@OlegDokuka OlegDokuka deleted the task/removes-1-1-derprecations branch August 6, 2020 09:32
@bclozel bclozel mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev requested changes

@spencergibb spencergibb Awaiting requested review from spencergibb

Assignees
No one assigned
Labels
breaking changes Changes that break API or behaviour for user attention task
Projects
None yet
Milestone
1.1 M1
Development

Successfully merging this pull request may close these issues.
2 participants
@OlegDokuka @rstoyanchev