-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress "Get the app" header promo #319
Comments
Agreed that we should hide this. I use Messenger on my phone, so I don't see this (i.e. I can't easily create a patch that with injected JavaScript hides it), so would be great if someone could submit a patch (you'd want to make changes to main.js) |
Create a patch that attempts to solve #319.
Looks like you could just display:none this class: "_s15". I have no idea what I'm doing, but I just created a pull request! OMG. How do I test this? Is |
Facebook's CSS class names are auto-generated and changes pretty often. We've been using React reflection to traverse the UI, to find nodes of interest. visibility:hidden means that the element still participates in layout (e.g. pushes other elements aside, flexbox resolution, etc). display:none means it's taken out of the tree entirely. visibility is useful for showing and hiding stuff to avoid causing an expensive re-layout and paint. display:none is useful for removing stuff (but not adding it back.) So you want "display:none" in this case @chrismessina |
But somehow Chatty doesn't have this problem, they removed it once and it has never shown again, so there has to be some other way around this, if you say they change css classe quite often. |
Hi! I’m running the last release and I’m the black promo bar still visible. :( |
Updates on this? Just downloaded the app and this has been annoying like the browser version. |
Since I use Messenger on my phone, I don't see the banner, meaning I can't fix it.
|
|
Note to anyone trying to fix this: You can not use class names or anything that is translated text, since that changes often (class names are generated and translated text is different, obv) |
There's a new promo to "Get App" showing up that really doesn't make sense on desktop.
The text was updated successfully, but these errors were encountered: