-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Any idea what is causing the Travis failures @jbeemster? |
It's a version bump in a dependency not related to this PR. It passes on any version over Ruby 2.2. |
Morning @rslifka ! Any chance of getting this merged before the holidays? Having to choose between |
Hello @alexanderdean! I think you mean @robert2d :) It looks like it's failing when the dependency pulls in the latest |
We might need to lock the activesupport version back to be compatible with ruby ~2.0. Otherwise it might be time to leave them behind and drop support for older rubies. Im in favour of attempting to support anything >= 2.0 But that said i'm flat out till post Xmas. I'll try and get to this tomorrow though |
Awesome - thanks @robert2d ! Appreciate it. |
Alright, we can definitely drop 2.0.
|
There is no stated EOL date for 2.1 that I can find apart from a mention on Stepping back... if 2.1 is a huge problem to support, then we need to consider our ability to support the people using this given our limited resources, and being vocal about support here on GitHub. Since 2012 I have made the decision to support as much as possible without significant personal cost. I am in favour of dropping 2.0 and 2.1 support. If someone on 2.1 or earlier wants to contribute the ability for older versions to be supported, then by all means :) |
Im just pushing a branch now which disables testing on travis for 2.0 and 2.1. I'll merge post tests passing, then rebuild this pull request. |
Amazing, thanks both! |
Going to merge this in now and then run a manual build on travis |
Its in the wild guys: https://rubygems.org/gems/elasticity/versions/6.0.9 hope that helps you relax before Xmas @alexanderdean |
Thanks so much @robert2d ! |
This PR adds the ability to attach EBS configuration options to instance groups which should allow the use of EBS only instance types such as
m4
andc4
.