url data can be reinitialized #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 14, 2018
lib/stringex/acts_as_url.rb
Outdated
| @@ -96,6 +96,13 @@ def included(base = nil, &block) | |||
| def initialize_urls | |||
| acts_as_url_configuration.adapter.initialize_urls! self | |||
| end | |||
|
|
|||
| # Initialize the url fields for the records that need it. Designed for people who want to update | |||
| # <tt>acts_as_url</tt> support once there's already development/production data they'd | |||
There was a problem hiding this comment.
Line is too long. [92/80]
lib/stringex/acts_as_url.rb
Outdated
| @@ -96,6 +96,13 @@ def included(base = nil, &block) | |||
| def initialize_urls | |||
| acts_as_url_configuration.adapter.initialize_urls! self | |||
| end | |||
|
|
|||
| # Initialize the url fields for the records that need it. Designed for people who want to update | |||
There was a problem hiding this comment.
Line is too long. [102/80]
aashish
force-pushed
the
reinitialize_urls
branch
from
41e3c39 to
54de5d2
Compare
houndci-bot
reviewed
Mar 14, 2018
lib/stringex/acts_as_url.rb
Outdated
| @@ -96,6 +96,13 @@ def included(base = nil, &block) | |||
| def initialize_urls | |||
| acts_as_url_configuration.adapter.initialize_urls! self | |||
| end | |||
|
|
|||
| # Renitialize the url fields for the all records. Designed for people who want to update | |||
There was a problem hiding this comment.
Line is too long. [94/80]
houndci-bot
reviewed
Mar 14, 2018
lib/stringex/acts_as_url.rb
Outdated
| # encoding: UTF-8 | ||
| require "stringex/acts_as_url/adapter" | ||
|
|
||
| require 'stringex/acts_as_url/adapter' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
lib/stringex/acts_as_url.rb
Outdated
| @@ -1,5 +1,5 @@ | |||
| # encoding: UTF-8 | |||
| require "stringex/acts_as_url/adapter" | |||
|
|
|||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
houndci-bot
reviewed
Mar 14, 2018
lib/stringex/acts_as_url.rb
Outdated
| # encoding: UTF-8 | ||
| require "stringex/acts_as_url/adapter" | ||
|
|
||
| require 'stringex/acts_as_url/adapter' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
lib/stringex/acts_as_url.rb
Outdated
| @@ -1,5 +1,5 @@ | |||
| # encoding: UTF-8 | |||
| require "stringex/acts_as_url/adapter" | |||
|
|
|||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
houndci-bot
reviewed
Mar 14, 2018
| @@ -96,6 +96,13 @@ def included(base = nil, &block) | |||
| def initialize_urls | |||
| acts_as_url_configuration.adapter.initialize_urls! self | |||
| end | |||
|
|
|||
| # Renitialize the url fields for the all records. Designed for people who | |||
| # want to update <tt>acts_as_url</tt> support once there's already | |||
There was a problem hiding this comment.
Trailing whitespace detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will able to update/reinitialize the
urldatabase column with existing data.