This repository has been archived by the owner on May 8, 2023. It is now read-only.
Fix for #Issue6: ganache installation issue #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: rsksmart#6 Install last Truffle
rm -rf ganache
|
This pull request fixes 16 alerts when merging c4f656a into 05310a5 - view on LGTM.com fixed alerts:
|
Used ganache branch 2.3.2
|
This pull request fixes 16 alerts when merging 181454b into 05310a5 - view on LGTM.com fixed alerts:
|
Replaced EIP20.sol impl & InterfaceEIP20.sol (proposal) with ERC20.sol impl & IERP20.sol (proposed). Perhaps I'll add a not on IEP/ERC for newbie even if I think most guys using such things should know what they are manipulating.
Updated deps through mcu
As I updated eip20 with ERC20, removed old IEP20
|
Updated old smart contract implem and interface (EIP20/InterfaceEIP20) from ConsenSys with implem & interface from OpenZeppelin:
|
|
This pull request fixes 16 alerts when merging 1a5678b into 05310a5 - view on LGTM.com fixed alerts:
|
Used smart contracts from OpenZeppelin
Added deps from openzeppelin ERC20 contracts
|
This pull request fixes 16 alerts when merging 82a74f5 into 05310a5 - view on LGTM.com fixed alerts:
|
Changed token from EIP20 to ERC20 => adapted script accordingly
|
This pull request fixes 16 alerts when merging 6eb0600 into 05310a5 - view on LGTM.com fixed alerts:
|
Adapt deployer script to adapt to erc20 constructor params
|
This pull request fixes 16 alerts when merging 8bf4a5f into 05310a5 - view on LGTM.com fixed alerts:
|
Contracts build are OpenZeppelin ones and truffle.config.js was generated from truffle init and was added keys as original truffle.config.js
|
This pull request fixes 16 alerts when merging 2ac5b32 into 05310a5 - view on LGTM.com fixed alerts:
|
Add a new token by derivation from OpenZeppelin ERC20 one Also updated solc version request (OpenZeppelin uses solc 0.8.0
|
Do not merge please ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has to be merged with (or before) the devportal PR #595
It propose a fix for truffle & ganache usage in the tuto (issue #6)