Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TBRE-354] Add proxies as named accounts in Hardhat config #259

Merged
merged 2 commits into from
Aug 27, 2021
Merged

[TBRE-354] Add proxies as named accounts in Hardhat config #259

merged 2 commits into from
Aug 27, 2021

Conversation

marcciosilva
Copy link
Contributor

  • Add proxies as named accounts in Hardhat config
  • Avoid re-deploying if they already exist for the current network
  • Add Prettier config por JS files (reformat all files associated to the feature)

marcciosilva
marcciosilva commented Aug 26, 2021
View reviewed changes
bridge/.prettierrc.json Outdated Show resolved Hide resolved
@marcciosilva marcciosilva force-pushed the feature/add-proxies-as-named-accounts branch from 8e4233c to 8b632d3 Compare August 26, 2021 17:41
@marcciosilva marcciosilva requested a review from pmprete August 26, 2021 17:41
@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2021

This pull request introduces 1 alert when merging 8b632d3 into 0e895d9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@marcciosilva marcciosilva force-pushed the feature/add-proxies-as-named-accounts branch from 8b632d3 to 3fd84d6 Compare August 26, 2021 17:47
Add proxies as named accounts, check if they exist before deploying t…
62a0a94 
…hem in migrations, refactor associated files (having added Prettier config for JS files)
@marcciosilva marcciosilva force-pushed the feature/add-proxies-as-named-accounts branch from 3fd84d6 to 62a0a94 Compare August 26, 2021 17:52
@marcciosilva marcciosilva changed the title Add proxies as named accounts in Hardhat config [TBRE-354] Add proxies as named accounts in Hardhat config Aug 26, 2021
@coveralls
Copy link

coveralls commented Aug 26, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 98.27% when pulling 2d2b55f on feature/add-proxies-as-named-accounts into 0e895d9 on master.

pmprete
pmprete reviewed Aug 26, 2021
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except my comments looks good

bridge/.prettierrc.json Outdated Show resolved Hide resolved
bridge/deploy/01_deploy_multiSigWallet.js Outdated Show resolved Hide resolved
bridge/hardhat.config.js Show resolved Hide resolved
bridge/deploy/22_deploy_federation.js Outdated Show resolved Hide resolved
Add missing prettier dependency, move prettier config to package.json…
2d2b55f 
… for bridge JS files, reformat all files related to PR, use bridge proxy in 22_deploy_federation if available instead of deploying the contract
@marcciosilva marcciosilva force-pushed the feature/add-proxies-as-named-accounts branch from dbac83e to 2d2b55f Compare August 27, 2021 13:02
@marcciosilva marcciosilva requested a review from pmprete August 27, 2021 13:23
pmprete
pmprete approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@RafilxTenfen RafilxTenfen mentioned this pull request Aug 27, 2021
Merged
6 tasks
@marcciosilva marcciosilva merged commit ac63f4b into master Aug 27, 2021
@marcciosilva marcciosilva deleted the feature/add-proxies-as-named-accounts branch August 27, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmprete pmprete pmprete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcciosilva @coveralls @pmprete