Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage step to circle CI pipeline, add coveralls dependency #246

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Add code coverage step to circle CI pipeline, add coveralls dependency #246

merged 4 commits into from
Aug 24, 2021

Conversation

marcciosilva
Copy link
Contributor

@marcciosilva marcciosilva commented Aug 12, 2021 •
edited
Loading

  • Add coverage step to circleci pipeline (remove Bridge's unit testing phase, since the coverage one already runs those tests)
  • Add coveralls' coverage badge to Bridge's README.md
  • Fix typo in the Bridge's deployIntegrationTest npm script

@marcciosilva marcciosilva force-pushed the feature/add-coverage-check-to-ci branch 3 times, most recently from c7cb355 to 6ac5171 Compare August 12, 2021 20:26
@RafilxTenfen
Copy link
Contributor

Nice! :D

@marcciosilva marcciosilva force-pushed the feature/add-coverage-check-to-ci branch 3 times, most recently from dca1483 to 9dee375 Compare August 13, 2021 15:15
pmprete
pmprete previously approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Marccio! but i think we need to fix the time it takes to the tests before merging this.
Coverage takes more resources than normal tests, and it's getting to many errors from timeout at the moment, so i would wait we fix that before merging this one

@marcciosilva marcciosilva force-pushed the feature/add-coverage-check-to-ci branch from 9dee375 to c8b078e Compare August 24, 2021 15:55
@marcciosilva marcciosilva force-pushed the feature/add-coverage-check-to-ci branch from 914aa75 to 12166d1 Compare August 24, 2021 16:24
@marcciosilva marcciosilva requested a review from pmprete August 24, 2021 16:30
pmprete
pmprete approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.circleci/config.yml
version: 2
version: 2.1
orbs:
coveralls: coveralls/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awsome did not know about this 💯

@pmprete pmprete merged commit 92ad759 into master Aug 24, 2021
@pmprete pmprete deleted the feature/add-coverage-check-to-ci branch August 24, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmprete pmprete pmprete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcciosilva @RafilxTenfen @pmprete