Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Changes PT-BR #709

Merged
merged 33 commits into from
Jun 28, 2021
Merged

Changes PT-BR #709

merged 33 commits into from
Jun 28, 2021

Conversation

bitcoinuser
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • fix: bug fixes, e.g. fix Button color on DarkTheme.
  • feat: new features, e.g. add Snackbar component.
  • refactor: code refactor, e.g. new folder structure for components.
  • docs: changes into documentation, e.g. add usage example for Button.
  • test: adding or updating tests, eg unit, snapshot testing.
  • chore: tooling changes, e.g. change circleci config.
  • BREAKING CHANGE: for changes that break existing usage, e.g. change API of a component.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Other information:

  • SCREENSHOTS:

Copy link
Collaborator

@patogallaiovlabs patogallaiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not change "ativo" to "criptoativo", its pretty obvious that we are talking about crypto since its a wallet, and we would also need to change in the rest of the languages.
Apart from that, I think its a nice PR :)

@patogallaiovlabs patogallaiovlabs added this to the v2.0.1 milestone Jun 25, 2021
"addWallet": "Adicionar carteira",
"readOnly": "Somente leitura"
},
"history": {
"noTransNote": "Não foram encontradas transações realizadas com este ativo.",
"noTransNote": "Não foram encontradas transações realizadas com este criptoativo.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"noTransNote": "Não foram encontradas transações realizadas com este criptoativo.",
"noTransNote": "Não foram encontradas transações realizadas com este ativo.",

@bitcoinuser
Copy link
Contributor Author

I would not change "ativo" to "criptoativo", its pretty obvious that we are talking about crypto since its a wallet, and we would also need to change in the rest of the languages.
Apart from that, I think its a nice PR :)

Done.

Copy link
Collaborator

@patogallaiovlabs patogallaiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patogallaiovlabs patogallaiovlabs merged commit 6d1ec53 into rsksmart:master Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants