Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

chore: update react-native from 0.59.x to 0.60.x #690

Merged
merged 10 commits into from
Jun 18, 2021
Merged

Conversation

patogallaiovlabs
Copy link
Collaborator

@patogallaiovlabs patogallaiovlabs commented May 20, 2021

Description

  • Commit 3f9f8e3 corresponds with npm audit fix --force.

Motivation and Context

In order to remove vulnerable dependencies, it is required that we start by upgrading React/React-Native to the last version (0.64).
But to go directly to last version, could be huge and messy, so we decided to split it in 1 version at a time, incrementally.

How Has This Been Tested?

Run basic operations in both platforms (Android/iOS)

Types of changes

  • fix: bug fixes, e.g. fix Button color on DarkTheme.
  • feat: new features, e.g. add Snackbar component.
  • refactor: code refactor, e.g. new folder structure for components.
  • docs: changes into documentation, e.g. add usage example for Button.
  • test: adding or updating tests, eg unit, snapshot testing.
  • chore: tooling changes, e.g. change circleci config.
  • BREAKING CHANGE: for changes that break existing usage, e.g. change API of a component.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)

NPM Audit

  • Before this PR:
    • found 347 vulnerabilities (40 low, 225 moderate, 82 high) in 1977 scanned packages
  • After this PR:
    • found 239 vulnerabilities (26 low, 154 moderate, 59 high) in 2179 scanned packages

@patogallaiovlabs patogallaiovlabs changed the title chore: update react-native from 0.59.x to 0.64.x WIP/chore: update react-native from 0.59.x to 0.64.x May 20, 2021
@patogallaiovlabs patogallaiovlabs self-assigned this May 20, 2021
@patogallaiovlabs patogallaiovlabs added this to the v2.0.0 milestone May 20, 2021
Copy link
Contributor

@lucachaco lucachaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and worked.

@patogallaiovlabs patogallaiovlabs changed the title WIP/chore: update react-native from 0.59.x to 0.64.x WIP/chore: update react-native from 0.59.x to 0.60.x Jun 7, 2021
@patogallaiovlabs patogallaiovlabs marked this pull request as ready for review June 7, 2021 20:57
@patogallaiovlabs patogallaiovlabs changed the title WIP/chore: update react-native from 0.59.x to 0.60.x chore: update react-native from 0.59.x to 0.60.x Jun 7, 2021
@lucachaco
Copy link
Contributor

tRBC sent with android

image

Copy link
Contributor

@martinmedina martinmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments to make, maybe the README update could have been done in another PR. Same for carrousel dependency change.

Looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants