This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
chore: update react-native from 0.59.x to 0.60.x #690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patogallaiovlabs
changed the title
chore: update react-native from 0.59.x to 0.64.x
WIP/chore: update react-native from 0.59.x to 0.64.x
May 20, 2021
lucachaco
approved these changes
May 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally and worked.
patogallaiovlabs
changed the title
WIP/chore: update react-native from 0.59.x to 0.64.x
WIP/chore: update react-native from 0.59.x to 0.60.x
Jun 7, 2021
patogallaiovlabs
force-pushed
the
upgrade_deps
branch
from
June 7, 2021 15:50
6f9a195
to
29397de
Compare
patogallaiovlabs
changed the title
WIP/chore: update react-native from 0.59.x to 0.60.x
chore: update react-native from 0.59.x to 0.60.x
Jun 7, 2021
…class when started
patogallaiovlabs
force-pushed
the
upgrade_deps
branch
from
June 9, 2021 18:10
c377981
to
d54bc8f
Compare
11 tasks
martinmedina
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major comments to make, maybe the README update could have been done in another PR. Same for carrousel dependency change.
Looks good!
This was referenced Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm audit fix --force
.Motivation and Context
In order to remove vulnerable dependencies, it is required that we start by upgrading React/React-Native to the last version (0.64).
But to go directly to last version, could be huge and messy, so we decided to split it in 1 version at a time, incrementally.
How Has This Been Tested?
Run basic operations in both platforms (Android/iOS)
Types of changes
Checklist:
NPM Audit