Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enable #456

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Fix enable #456

merged 2 commits into from
Dec 7, 2021

Conversation

ilanolkies
Copy link
Contributor

rLogin provider for hardware devices do not use .enable

@ilanolkies ilanolkies added the bug Something isn't working label Dec 7, 2021
jessgusclark
jessgusclark approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that it is working if this method was not available. It's good to fix it, however, it leaves me with questions.

@ilanolkies ilanolkies merged commit fd21cda into develop Dec 7, 2021
@ilanolkies ilanolkies mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessgusclark jessgusclark jessgusclark approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilanolkies @jessgusclark