Merge #444

444: More sled pinstore changes r=koivunej a=koivunej

This PR adds:

- docs for the feature and the struct
- even longer TODOs, but with less FIXMEs
- pin key reuse in some cases from `get_pinned_mode`
- use `TransactionalTree::flush` instead of `Db::flush_async`, see #443
- the use of `spawn_blocking` to do sled operations

Closes #443.

Co-authored-by: Joonas Koivunen <[email protected]>

CHANGELOG.md

@@ -4,14 +4,15 @@
 * ci: update go-ipfs to `0.7.0` for interop tests [#428]
 * refactor(http): introduce `Config` as the facade for configuration [#423]
 * feat(http): create `Profile` abstraction [#421]
-* feat: `sled` pinstore [#439], [#442]
+* feat: `sled` pinstore [#439], [#442], [#444]
 
 [#429]: https://github.com/rs-ipfs/rust-ipfs/pull/429
 [#428]: https://github.com/rs-ipfs/rust-ipfs/pull/428
 [#423]: https://github.com/rs-ipfs/rust-ipfs/pull/423
 [#421]: https://github.com/rs-ipfs/rust-ipfs/pull/421
 [#439]: https://github.com/rs-ipfs/rust-ipfs/pull/439
 [#442]: https://github.com/rs-ipfs/rust-ipfs/pull/442
+[#442]: https://github.com/rs-ipfs/rust-ipfs/pull/444
 
 # 0.2.1
 

Cargo.toml

@@ -10,6 +10,9 @@ version = "0.2.1"
 
 [features]
 default = []
+
+# feature will enable sled_data_store use in ipfs::Types (default used by ipfs-http for example)
+# sled dependency is not guarded by this to keep compiling and test the pinstore.
 sled_data_store = []
 test_go_interop = []
 test_js_interop = []