-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #49 from rryqszq4/development
[pr] release version to 0.0.17
- Loading branch information
Showing
4 changed files
with
22 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanhey hi, ngx_php7 released a new version, please help update.
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last 2 runs failed, and there aren't any changes only the php updates.
https://tfb-status.techempower.com/unzip/results.2019-06-08-20-01-34-978.zip/results/20190605052508/php-ngx/run/php-ngx.log
The dockerfile:
https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/PHP/php/php-ngx.dockerfile
Not changed in the last 4 months, and only failed in the last 2 runs.
Ready the new version 0.0.17, nignx 1.17.0 and ubuntu 19.04, all compiled without problems.
https://github.com/joanhey/FrameworkBenchmarks/commits/php-ngx
But still with the same problem:
php-ngx: 2019/06/10 13:30:35 [alert] 7#0: worker process xx exited on signal 11 (core dumped)
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanhey
A new pull request #50 about this problem, please waiting for a new tags.
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The swoole server don't have database pooling.
And they use that:
https://github.com/joanhey/FrameworkBenchmarks/blob/php-ngx/frameworks/PHP/swoole/swoole-server.php#L203-L263
Perhaps you can code something similar.
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swoole is very powerful, but I still refer to the openresty design because it affects me too deeply.Will use the connection pool of nginx.
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanhey
Currently, the non-blocking mysql driver https://github.com/rryqszq4/ngx_php7/blob/master/t/lib/mysql.php is ready, but the short link does not have a connection pool, and after adding some demos, you can run it. The connection pool still needs to wait for the first time.
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question:
Will the new https://wiki.php.net/rfc/preload affect the performance in php-ngx?
Or will be almost the same to php-ngx ?
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working correctly with 0.0.18.
Just send the PR.
383bc95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanhey
I think preload does not affect the performance of ngx_php.