Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export isBlocked alongside rrweb.record #1534

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eoghanmurray
Copy link
Contributor

This is a speculative PR as I'm wondering whether we shouldn't be leaving this file well enough alone until we migrate rrweb/record/index.ts on top of it.

Goal here is to expose isBlocked to the recording website.

There's also a question as to whether the entirity of the record.utils modulue should be exposed on the record side.

…iding config if recording has already started
Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: 38e251c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eoghanmurray eoghanmurray changed the title Record: Export isBlocked that Export isBlocked alongside rrweb.record Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant