Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix yarn dev #1501

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Chore: Fix yarn dev #1501

merged 3 commits into from
Jun 10, 2024

Conversation

Juice10
Copy link
Contributor

@Juice10 Juice10 commented Jun 10, 2024

This pull request includes an upgrade to the turbo package and fixes an issue with the yarn dev command. The upgrade ensures that the latest version of turbo is used, while the fix addresses an issue with the dist directory being cleared which broke the dependants dev commands.

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: b42aec9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eoghanmurray
Copy link
Contributor

I don't fully understand these changes but happy to approve :)

@Juice10 Juice10 merged commit 88e23d8 into master Jun 10, 2024
11 checks passed
@Juice10 Juice10 deleted the juice10/yarn-dev branch June 10, 2024 10:04
"globalDependencies": [
".eslintrc.js",
".prettierrc",
"lerna.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Juice10 Do you think it's OK to remove lerna config since we are not using it anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've created a PR for it here: #1506

jeffdnguyen pushed a commit to pendo-io/rrweb that referenced this pull request Jul 29, 2024
* Chore: upgrade turbo & fix yarn dev
jeffdnguyen pushed a commit to pendo-io/rrweb that referenced this pull request Jul 29, 2024
* Chore: upgrade turbo & fix yarn dev
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Oct 22, 2024
* Chore: upgrade turbo & fix yarn dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants