-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Fix yarn dev #1501
Chore: Fix yarn dev #1501
Conversation
🦋 Changeset detectedLatest commit: b42aec9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c57806d
to
cb3f53e
Compare
I don't fully understand these changes but happy to approve :) |
"globalDependencies": [ | ||
".eslintrc.js", | ||
".prettierrc", | ||
"lerna.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Juice10 Do you think it's OK to remove lerna config since we are not using it anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I've created a PR for it here: #1506
* Chore: upgrade turbo & fix yarn dev
* Chore: upgrade turbo & fix yarn dev
* Chore: upgrade turbo & fix yarn dev
This pull request includes an upgrade to the turbo package and fixes an issue with the yarn dev command. The upgrade ensures that the latest version of turbo is used, while the fix addresses an issue with the dist directory being cleared which broke the dependants dev commands.