Don't trigger provider scoped lints in tests #3056
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3056 +/- ##
==========================================
+ Coverage 95.29% 95.30% +0.01%
==========================================
Files 53 53
Lines 2274 2281 +7
==========================================
+ Hits 2167 2174 +7
Misses 107 107 |
lockieRichter
force-pushed
the
handle-tests-for-lints
branch
from
c3fc922
to
005009a
Compare
lockieRichter
force-pushed
the
handle-tests-for-lints
branch
2 times, most recently
from
d0b6658
to
9ca4115
Compare
lockieRichter
force-pushed
the
handle-tests-for-lints
branch
from
9ca4115
to
4a22b7f
Compare
| @@ -14,3 +14,4 @@ dependency_overrides: | |||
| path: ../riverpod_annotation | |||
| riverpod_lint: | |||
| path: ../riverpod_lint | |||
| test_api: ^0.6.1 | |||
There was a problem hiding this comment.
flutter_test has a pinned dependency on test_api: 0.6.0 but the test package needs test_api: ^0.61. Needed to do this to get the packages all playing nicely.
| void someTestFunction() { | ||
| testWidgets('override repositoryProvider in test', (tester) async { | ||
| await tester.pumpWidget( | ||
| ProviderScope( |
There was a problem hiding this comment.
We need a test where ProviderScope is not prevent in pumpWidget
And one where ProviderScope is prevent within pumpWidget, but is not the very first widget
There was a problem hiding this comment.
Wil do, slick!
There was a problem hiding this comment.
Added some more tests covering these cases.
|
Looking good, thanks! |
Updates the
scoped_providers_should_specify_dependenciesto ignore instances of using pumpWidget in tests