Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links on .family modifier docs page #2951

Closed
mvarendorff opened this issue Oct 4, 2023 · 1 comment
Closed

Broken links on .family modifier docs page #2951

mvarendorff opened this issue Oct 4, 2023 · 1 comment
Assignees
@rrousselGit
Labels
documentation Improvements or additions to documentation needs triage

Comments

@mvarendorff
Copy link

Describe what scenario you think is uncovered by the existing examples/articles

The current documentation on the family modifier is rendered incorrectly. Specifically the links in the first sentence are rendered to the DOM as empty div instead of a tags.

Describe why existing examples/articles do not cover this case

N/A

Additional context

grafik

I am down to create a PR for this in a couple hours when I am off work.
@mvarendorff mvarendorff added documentation Improvements or additions to documentation needs triage labels Oct 4, 2023
@droidbg
Copy link

droidbg commented Oct 5, 2023

@geisterfurz007 @rrousselGit I like to pick this up, can you assign it to me.

droidbg pushed a commit to droidbg/riverpod that referenced this issue Oct 5, 2023
@binnigoel
[rrousselGit#2951] Fix. Broken links on .family modifier docs page
78189f9
droidbg added a commit to droidbg/riverpod that referenced this issue Oct 5, 2023
@droidbg
[rrousselGit#2951] Fix. Broken links on .family modifier docs page
c1a553d
@droidbg droidbg mentioned this issue Oct 5, 2023
Merged
4 tasks
rrousselGit pushed a commit that referenced this issue Oct 5, 2023
@droidbg
Fix. Broken links on .family modifier docs page (#2956)
0c28a2a 
fixes #2951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrousselGit rrousselGit

Labels
documentation Improvements or additions to documentation needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rrousselGit @mvarendorff @droidbg