-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add draggable_scrollable_controller #417
Conversation
I'd say this hook would benefit from the changes in #415 Current implementation of |
@davidmartos96 Good point! |
Fixed dispose issue |
packages/flutter_hooks/lib/src/draggable_scrollable_controller.dart
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 98.36% 98.38% +0.02%
==========================================
Files 21 22 +1
Lines 854 868 +14
==========================================
+ Hits 840 854 +14
Misses 14 14 ☔ View full report in Codecov by Sentry. |
packages/flutter_hooks/lib/src/draggable_scrollable_controller.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after a little format change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could you add it to the README? And the changelog too, under the form of:
## Unreleased patch
- Added <...>
….dart Co-authored-by: Remi Rousselet <[email protected]>
Done |
packages/flutter_hooks/CHANGELOG.md
Outdated
@@ -1,3 +1,8 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
LGTM thanks! |
Added useDraggableScrollableController with tests
Didn't edit readme or changelog
Lmk if you want the tests changed