Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic GestureRecognizer and TapGestureRecognizer hooks #191

Closed
wants to merge 4 commits into from
Closed

Generic GestureRecognizer and TapGestureRecognizer hooks #191

wants to merge 4 commits into from

Conversation

Albert221
Copy link
Contributor

See #190.

@Albert221 Albert221 mentioned this pull request Oct 3, 2020
14 tasks
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #191 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   99.67%   99.68%           
=======================================
  Files          10       11    +1     
  Lines         616      633   +17     
=======================================
+ Hits          614      631   +17     
  Misses          2        2           
Impacted Files Coverage Δ
lib/src/gesture_recognizers.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89a491...9dade1c. Read the comment docs.

@Albert221 Albert221 marked this pull request as ready for review October 3, 2020 14:46
@rrousselGit
Copy link
Owner

Closing as per #190 (comment)

I appreciate your work, but I just don't think that is the correct path for this kind of thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants