Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character encoding for English, German, French, Italian, Japanese and Spanish #9

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

richirisu
Copy link
Contributor

This pull request adds support for the character encodings of the English, German, French, Italian, and Spanish translation patches as well as the original Japanese release.

Codewise, a character name adapter was added for each language. The encoding mappings are stored in separate JSON files. Note, the original character name adapter is still present, although unused at the moment.

Regarding the UI, a combo box was added in order to be able to select the language of the used translation patch. Unfortunately, there seems to be no way to determine the language automatically from the save file alone.

Please refer to the newly added documents for more details: character encoding.md and language support.md.

Please let me know if there is anything wrong with the encoding mappings or the source code in general.

Enjoy :)

@rrooij
Copy link
Owner

rrooij commented Aug 3, 2022

Thank you so much! I will try to find some time to review it. 😄

@rrooij
Copy link
Owner

rrooij commented Aug 4, 2022

Works great! Some minor things for in the future:

  • It would be nice if we had tests as well
  • Perhaps we should mention the supported ROM names in the language entries in the GUI, because it may be confusing
  • A lot of save files have the name [ROM_NAME].srm. We could pick up the language automatically according to the save file name.

And perhaps we should make really clear that this is the language of the ROM and not the language of the game itself.

@rrooij rrooij merged commit 192a87e into rrooij:main Aug 4, 2022
@richirisu
Copy link
Contributor Author

Hey, cool that you took the time to review it. I have been a bit busy myself, but I finally found the time to think about your considerations :)

You're right, it's definitely an option to look at the filename in order to determine the language. I haven't thought about that. I had just done some investigation on the safe file data itself, and sadly, no translation patch information is written to the safe file. On the other hand, this also means that the save files are interchangeable no matter the translation patch. Which is a cool thing.

Anyhow, I have done some research regarding the filenames, and I also took the liberty to program it already :D

As you have requested, this time I also provided tests for the several filenames.

However, I am not quite sure on how to test the encodings from this pull request here without getting tideous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants