Add character encoding for English, German, French, Italian, Japanese and Spanish #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the character encodings of the English, German, French, Italian, and Spanish translation patches as well as the original Japanese release.
Codewise, a character name adapter was added for each language. The encoding mappings are stored in separate JSON files. Note, the original character name adapter is still present, although unused at the moment.
Regarding the UI, a combo box was added in order to be able to select the language of the used translation patch. Unfortunately, there seems to be no way to determine the language automatically from the save file alone.
Please refer to the newly added documents for more details:
character encoding.md
andlanguage support.md
.Please let me know if there is anything wrong with the encoding mappings or the source code in general.
Enjoy :)