Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSR Publish and Documentation Release #467

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

pieterocp
Copy link
Contributor

Summary

Should fix ci by setting ci to use node 20 instead.

Description

Sets the version of node used in github actions to 20.

Related Issues

Fixes #463

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • Not part of this, but this implicitly suggest that this library won't install with node 18 anymore (outside of using `ignore-engines). This is more of a question of if we should support the minimum versions that align with the minimum versions of vue/nuxt or if we want to help everyone bump up. (The latter is a good way to do it, but tooling working on a huge range of different underlying versions does make their adoption easier, albeit adds a lot of headaches making sure it runs well with a large range of runtime environments.)
  • Documentation update

(Not a github actions wizard so there might be a way to run this in some pre-deployment tooling to verify this works, I think it should but only when executing it can I be sure.)

should fix ci by setting ci to use node 20 instead
Copy link

logo Vue Mess Detector Analysis Results

PR Code Health Full Code Health

🚨 New Errors: 2
⚠️ New Warnings: 4
✅ Fixed Errors: 0
🔧 Fixed Warnings: 0
📝 Total Lines: 97
📁 Total Files: 3

New Issues

- src/helpers/setupFileIgnoreList.ts:
  rrd ~ else conditions: else clauses found (1) 🚨
  rrd ~ function size: function (checkFileIgnoreRules#5) is too long: 22 lines 🚨
- src/helpers/setupFileIgnoreList.test.ts:
  rrd ~ magic numbers: magic numbers found (line #23 magic number: 2) 🚨
  rrd ~ magic numbers: magic numbers found (line #26 magic number: 3) 🚨

🔍 Download Full Analysis Details

For any issues or feedback, feel free to report them here.

Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/rrd108/vue-mess-detector@467

commit: aa10c86

@David-Pena
Copy link
Collaborator

David-Pena commented Nov 25, 2024

Not part of this, but this implicitly suggest that this library won't install with node 18 anymore (outside of using `ignore-engines). This is more of a question of if we should support the minimum versions that align with the minimum versions of vue/nuxt or if we want to help everyone bump up. (The latter is a good way to do it, but tooling working on a huge range of different underlying versions does make their adoption easier, albeit adds a lot of headaches making sure it runs well with a large range of runtime environments.)

@pieterocp Let's bring this to the Discord so we can discuss it with @rrd108

@rrd108 rrd108 merged commit 361540f into rrd108:main Dec 27, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc release action fails
3 participants