Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc release action fails #463

Open
rrd108 opened this issue Nov 21, 2024 · 4 comments · May be fixed by #467
Open

doc release action fails #463

rrd108 opened this issue Nov 21, 2024 · 4 comments · May be fixed by #467

Comments

@rrd108
Copy link
Owner

rrd108 commented Nov 21, 2024

see: https://github.com/rrd108/vue-mess-detector/actions/runs/11953832934/job/33323294488
@rrd108 rrd108 changed the title doc release fails doc release action fails Nov 21, 2024
@pieterocp
Copy link
Contributor

Looks like one of the dependencies has dropped support for node 18 (isaacs/minimatch@632e0da), so either time to pin it down or bump up the node version runner. (same for other actions erroring, e.g. Jsr Runner 0.65.0

error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.20.5"
error Found incompatible module.

@David-Pena
Copy link
Collaborator

David-Pena commented Nov 21, 2024 •
edited
Loading

Thanks for the details @pieterocp 🙏🏻

How do we approach this? @rrd108

Case A) Downgrade minimatch to a version that still supports node: 18
Case B) Increase engine node to 20

@rrd108
Copy link
Owner Author

rrd108 commented Nov 22, 2024

As node 22 is active and 20 is maitnenace LTS I think we can bump up to node 20

@David-Pena
Copy link
Collaborator

@pieterocp would you like to contribute with the bump to node 20?

pieterocp added a commit to pieterocp/vue-mess-detector that referenced this issue Nov 25, 2024
@pieterocp
Addresses rrd108#463
aa10c86 
should fix ci by setting ci to use node 20 instead
@pieterocp pieterocp linked a pull request Nov 25, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JSR Publish and Documentation Release pieterocp/vue-mess-detector
3 participants
@rrd108 @David-Pena @pieterocp