AWS: only cache instance requirements when needed #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
This PR reduces the number of unneeded
DescribeLaunchTemplateVersions
API calls. Previously there was a PR that only looked for instance requirements when needed kubernetes#5550. However this PR kubernetes#6245 introduced a regression where now it looks for instance requirements all the time.However in the original fix PR it was stated:
This PR makes it so we again only look for instance requirements if instance type overrides are not used.
This screenshot shows the huge increase in
DescribeLaunchTemplateVersions
API calls when we upgraded our cluster autoscaler to include the bug PR at 16:00 kubernetes#6245Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: