Remove all JavaScript files from the repository #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpominov
force-pushed
the
remove-code
branch
from
00aa55e to
fb80d0d
Compare
index.js
Outdated
| bimap: 'fantasy-land/bimap', | ||
| promap: 'fantasy-land/promap' | ||
| }; | ||
| var empty = {}; |
There was a problem hiding this comment.
Yeah, I thought about this. But not sure if it's OK for an NPM module to not have any files.
There was a problem hiding this comment.
It's fine. xyz only provides a readme and a shell script (no JavaScript files). npm doesn't mind. :)
rpominov
force-pushed
the
remove-code
branch
from
fb80d0d to
93c9e43
Compare
davidchambers
approved these changes
Feb 20, 2018
Avaq
approved these changes
Feb 20, 2018
|
OK, I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the main repository will contain only the specification itself it will be easier to maintain and version. We can place the code in accompanying repositories under
fantasylandorganization.This is not a new idea, @davidchambers already doing this in fantasyland#284 , this PR goes a bit further though.
Also, it's easier to remove what we would have to update otherwise. Please comment if you have a better course of action in mind.