Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove register_retire from rfpkg #25

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

eclipseo
Copy link
Contributor

Don't register again the retire command as it is already done
by pyrpkg. Starting Python 3.11, it creates an error.
See python/cpython#18605

Fix #24

Don't register again the retire command as it is already done
by pyrpkg. Starting Python 3.11, it creates an error.
See python/cpython#18605

Fix rpmfusion-infra#24
@eclipseo
Copy link
Contributor Author

The only difference was the wording:


            description='This command will remove all files from the repo, '
                        'leave a dead.package file for rpms or dead.module '
                        'file for modules, and push the changes.'

versus


            description='This command will remove all files from the repo, '
                        'leave a dead.package file, push the changes and '
                        'retire the package in pkgdb.'

Not sure it makes such a big difference.

I've searched for other methods, but there is no provision for removing a parser (proposed in 2015 but not pursued) or modifying an existing parser.

@sergiomb2
Copy link
Member

sergiomb2 commented Jun 27, 2022

and with python 3.10 (or previous) this works ?

@eclipseo
Copy link
Contributor Author

I have not tested it, but there is no reason it wouldn't. Adding twice the same subparsers was not something that was supposed to be done. Python 3.11 made it into an error, but there is no other behaviour change wrt Python 3.10 ad earlier.

@sergiomb2
Copy link
Member

ah ok

@sergiomb2 sergiomb2 merged commit 5f9850f into rpmfusion-infra:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11 support problems
2 participants