Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve build cloudflare in react 19 #74

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

ikhbaaalll
Copy link
Contributor

Fixes #

Description

Fix build for cloudflare workers in React 19,

Type of change

Please mark relevant options with an x in the brackets.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • [x ] Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

image

#3273
reference in astro

Copy link

pkg-pr-new bot commented Feb 5, 2025

Open in Stackblitz

npm i https://pkg.pr.new/rphlmr/react-router-hono-server@74

commit: fa74670

@rphlmr
Copy link
Owner

rphlmr commented Feb 5, 2025

Thanks for your help!

Don't bother with the lint stage, I will update your PR before merging it, this evening or tomorrow.

@rphlmr rphlmr merged commit ce0d210 into rphlmr:main Feb 6, 2025
4 checks passed
@rphlmr
Copy link
Owner

rphlmr commented Feb 6, 2025

@ikhbaaalll ikhbaaalll mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants