fix: img SVGs with no dimensions not scaling #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an `<img />` element has a `src` that is an SVG that has no `width` nor `height` defined, we got into a weird spot where the loaded element had `naturalWidth` and `naturalHeight` of `0`. This can differ between browsers, but most notably in Firefox. In Firefox, since this is `0`, the object fit calculations were dividing by zero, leading the scaling factor to go from its correct amount (scale to the browser window) to not scaling whatsoever and just centering the image on the screen at the same size it was rendered at. The fix here is to do what we do for other calculation functions and fallback to the image's rect measurements.
rpearce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an
<img />element has asrcthat is an SVG that has nowidthnorheightdefined, we got into a weird spot where the loaded element hadnaturalWidthandnaturalHeightof0. This can differ between browsers, but most notably in Firefox. In Firefox, since this is0, the object fit calculations were dividing by zero, leading the scaling factor to go from its correct amount (scale to the browser window) to not scaling whatsoever and just centering the image on the screen at the same size it was rendered at. The fix here is to do what we do for other calculation functions and fallback to the image's rect measurements.This also makes sure we use
decoding="async"on test images to make sure we're always testing the laziest images possible!