Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move on-target-tests back to the work space #762

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

ithinuel
Copy link
Member

@ithinuel ithinuel commented Feb 6, 2024

There’s no obvious reason to keep on-target-tests excluded from the
workspace. Plus, this simplifies significantly the github workflows.
@jannic
Copy link
Member

jannic commented Feb 7, 2024

Are you sure? I reverted that change and both the CI pipeline and the on-target tests still succeed.

Asides from that: @9names, you excluded the on-target-tests from the workspace in #457. As it seems like with ithinuels changes, the CI pipeline is happy with them added back to the workspace, do you think there's still some reason to keep them separate?

@jannic jannic requested a review from 9names February 7, 2024 08:00
@9names
Copy link
Member

9names commented Feb 7, 2024

I have no reason to exclude them from the workspace

Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me

@ithinuel
Copy link
Member Author

ithinuel commented Feb 7, 2024

@jannic "requires" in the sense that I'd like to avoid having to rebase the PRs, so having them merged in-order should help reduce unnecessary work.
(and this PR includes the changes of its preceding)

@jannic
Copy link
Member

jannic commented Feb 8, 2024

@jannic "requires" in the sense that I'd like to avoid having to rebase the PRs, so having them merged in-order should help reduce unnecessary work. (and this PR includes the changes of its preceding)

Ah ok, understand. Personally I prefer truly independent pull requests, but they of course have the risk of merge conflicts.

@jannic jannic merged commit 31ccfa3 into rp-rs:main Feb 8, 2024
6 checks passed
@ithinuel ithinuel deleted the move-on-target-tests branch February 8, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants