Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the new LAPS (April 2023 Update) #94

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

krikk
Copy link
Contributor

@krikk krikk commented Nov 14, 2023

modified the existing LAPS Dynamic folder to work with the "new" LAPS (April 2023 Update), This Version fetches the Connections out from AD (Get-ADComputer) and the LAPS user and Password also via AD (Get-LapsADPassword)

also solved the problem with german umlauts, added description field from AD

modified the existing LAPS Dynamic folder to work with the "new" LAPS (April 2023 Update), 
This Version fetches the Connections out from AD (Get-ADComputer) and the LAPS user and Password also via AD (Get-LapsADPassword)

also solved the problem with german umlauts, added description field from
@lemonmojo
Copy link
Member

@krikk This adds a completely new file to the repo new LAPS (Windows PowerShell).rdfx instead of replacing the original.
Is this new script not compatible with older versions of LAPS or did this happen accidentally?

@krikk
Copy link
Contributor Author

krikk commented Nov 28, 2023

the "new" LAPS (released April 2023) has new powershell Commands, which are different to the "old" one, so this script will only work with "new" LAPS and not with the old one, so it's better to offer both, ...the old one for people still using the old laps, and the "new" version for up-to-date Systems

@krikk
Copy link
Contributor Author

krikk commented Nov 28, 2023

and sorry about the naming, but Microsoft did this "bad" naming :)

new LAPS:
Windows LAPS is now available on the following OS platforms with the specified update or later installed:

Windows 11 22H2 - April 11 2023 Update
Windows 11 21H2 - April 11 2023 Update
Windows 10 - April 11 2023 Update
Windows Server 2022 - April 11 2023 Update
Windows Server 2019 - April 11 2023 Update

@lemonmojo
Copy link
Member

@krikk Thx for the clarification. So, should we maybe name the new script LAPS April 2023 (Windows PowerShell).rdfx instead of new LAPS (Windows PowerShell).rdfx to make that more clear?

@krikk
Copy link
Contributor Author

krikk commented Nov 29, 2023

as the "new" LAPS is inbuild into the OS with the April 2023 OS Updates, it will become the new standard very fast

so i would suggest the following:
rename the old "LAPS (Windows PowerShell).rdfe" to "LAPS (deprecated) (Windows PowerShell).rdfe" <- this because the the old LAPS need additional software and non-standard powershell Modules
and the new file (mine) to "LAPS April 2023 (Windows PowerShell).rdfe"

@lemonmojo
Copy link
Member

lemonmojo commented Nov 29, 2023

@krikk Yeah, that sounds good to me! Awaiting the changes...

@krikk
Copy link
Contributor Author

krikk commented Mar 29, 2024

nearly forgot this one, renamed like planned, i think it ready to merge

@eiabea eiabea merged commit 8a274a5 into royalapplications:master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants