Added rounding mode param to divide method #135
Conversation
Sword-of-GraySkull
force-pushed
the
patch_divide_rounding_mode
branch
from
e95b5b6 to
028237d
Compare
Sword-of-GraySkull
force-pushed
the
patch_divide_rounding_mode
branch
from
028237d to
06c9b91
Compare
Sword-of-GraySkull
force-pushed
the
patch_divide_rounding_mode
branch
from
06c9b91 to
c608d9e
Compare
|
@Jsoto22 Can you please rerun the workflows? |
|
npm-publish job seems to have not published the package. Because is_version is returned as false in the 'Check if tag is a version' step. Could you please assist? |
|
I'm currently looking into a few things I noticed come up in the workflow. I'll get back to you when I can. |
|
Have you been able to look up the npm-publish job failure? I can see that you are looking for any difference between the last published npm version and the latest git tag for the publish step to happen. But, I couldn't figure out when the new tag was created. |
|
Sorry, haven't had much time since. I'll prep a release to create the missing tag tomorrow if I can. |
|
Hey @Jsoto22 , I understand you're likely busy. But I wanted to follow up on the release request. Thanks for your time |
|
Sorry all, have been realy busy on the family front of things, and have not
been able to respond for quite a while. We need to bump the version
manually (npm version patch/minor/major) based on what type of changes.. if
there are a lot of new changes coming in, even though no old use case is
impacted, still make it a major version. Otherwise go with minor.
…On Sat, 13 Jul, 2024, 15:57 Sword-of-GraySkull, ***@***.***> wrote:
Hey @Jsoto22 <https://github.com/Jsoto22> , I understand you're likely
busy. But I wanted to follow up on the release request.
—
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6RZDA7ULP475KUKHY34JLZMD6ILAVCNFSM6AAAAABJYGVRQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWHA2DSMRQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks, @royNiladri for the update. I have manually updated the version from 2.0.7 to 2.0.8 in package.json. So, I believe we shouldn't bump the version with |
|
As mentioned, Could you create a tag for 2.0.8 and publish the version? |
|
Hi @Sword-of-GraySkull & @Jsoto22, Cheer🥳 |
Since the divide method lacks the rounding mode parameter, this line defaults the rounding to (HALF EVEN)
Hence, adding the rounding mode param to round the result of divide method to be rounded with other rounding options