Fix/preserve newline at end of notebooks #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix/preserve-newline-at-end-of-notebooks
By default notebooks are stored with a newline at the end of the file. Furthermore, not including a newline will cause the pre-commit hook 'end-of-file-fixer' to fail and add a newline. This triggers a never-ending loop of fails. This fix will ensure that any adjusted notebook does include a newline at the end of the file, preserving original behaviour and reducing interference with other pre-commit hooks.
In the sample config, update repository, version number and comment out bad default
|
Thanks for your contribution!!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Jupyter notebooks are stored with a newline at the end of the file. Furthermore, not including a newline will cause the pre-commit hook 'end-of-file-fixer' to fail and add a newline. This triggers a never-ending loop of fails.
This fix will ensure that any adjusted notebook does include a newline at the end of the file, preserving original behaviour when Jupyter saves a notebook and reducing interference with other pre-commit hooks.