Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth fragment styling #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Auth fragment styling #21

wants to merge 2 commits into from

Conversation

alesvaupotic
Copy link
Collaborator

I did what I could with styling to not change the whole concept. Protected page was set up with inverted theme and some global styles also messed with inputs.

We might think of a global css which can be deleted or updated on demand and each fragment would contribute to initially. It's a simple and quick way to replace styling in general on a new project.

Added a link to /protected route as there was none.

@diepoe
Copy link
Collaborator

diepoe commented Apr 21, 2021

Yeah, I like the idea. So what do you think about adding something like a CSS property to the blueprint?

@alesvaupotic
Copy link
Collaborator Author

Jakob will chime in on this one, with v3 in mind maybe.

@jakobrosenberg
Copy link
Member

We might think of a global css which can be deleted or updated on demand and each fragment would contribute to initially. It's a simple and quick way to replace styling in general on a new project.

I much agree. I've been looking for a minimal-class kinda framework that can provide default styling and easily be removed without leaving a mess of unused classes. Currently I like Milligram but am open to alternatives or adding some stackmix specific CSS.

@jakobrosenberg
Copy link
Member

Before I merge this what does the PR fix?

This is what I get with vite-navigation-auth-markdown-milligram-app

screenshots

image

image

image

image

image

image

@alesvaupotic
Copy link
Collaborator Author

Oh, sorry, with milligram you got styling. Never used that before. With just auth,vite I get the what was discussed in discord:
image

@alesvaupotic
Copy link
Collaborator Author

alesvaupotic commented Apr 22, 2021

Jakob, milligram looks just fine. How about including it into base, it's 2KB and really brings a lot to the table? Even being a Tailwind user myself, I can see benefits of including a lib like that to introduce some styling for the user. I mean, we import all these testing libs and stuff, it wont affect npm install times at all.

@jakobrosenberg
Copy link
Member

@alesvaupotic it should be already included by default. Should we add a comment to it that clarifies its purpose?

@alesvaupotic
Copy link
Collaborator Author

@jakobrosenberg Just ran npx stackmix -f auth,vite and I see no reference to milligram anywhere in generated source code.

@jakobrosenberg
Copy link
Member

Ah. You only get it by default if you run npx stackmix.

The -f is for unattended installs, so it'll assume you only want what you include.

@alesvaupotic
Copy link
Collaborator Author

OK, but you can't assume either that preselected fragments will end up in the user's output. I always deselect milligram in favor of tailwind, this is what I get:

image

So, it would be of great help if either some general styling is applied for any output generated by stackmix or there is no styling at all. I haven't digged thru repository to see when Auth fragment got internal styles, but now it's a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants