Patch/remove label shadows #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that shadows are not really needed. Font size (#173) is, in my opinion, the biggest visual issue at present. |
|
Also, the shadow direction (45°) conflicts with the OS X global illumination direction (straight top to bottom). This also applies to the diff boxes:
|
Actually we may cache NSShadow in the class variable.
Also use OSX UI bold font with little transparency, so text get's labels tint.
|
Rebased to latest
|
This improves readability of colors on different lanes.
|
FYI this is how it looks on Yosemite with proposed flat design (by this pull request)
|
|
Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually I think shadowless history looks great! Thanks for having compile time option for that, but I think you should consider shadowless as default.
Here's how it look here together with PDF icons (see my other merge).