Gitx crashes when trying to open any repo

[zoodor]

Trying to open any git repository in GitX since updating to 0.15.1869 causes the application to crash. I am on Lion (10.7.5).

This happens when trying to open any of my existing repos or even on an empty repository (after simply doing a git init).

Some details from the crash report that is generated:

Process:         GitX [904]
Path:            /Users/USER/*/GitX.app/Contents/MacOS/GitX
Identifier:      net.phere.GitX
Version:         0.15.1869 dev (0.15.1869)
Code Type:       X86-64 (Native)
Parent Process:  launchd [241]

Date/Time:       2014-05-12 09:31:21.600 +0100
OS Version:      Mac OS X 10.7.5 (11G63)
Report Version:  9

Interval Since Last Report:          2891004 sec
Crashes Since Last Report:           405
Per-App Interval Since Last Report:  314 sec
Per-App Crashes Since Last Report:   11
Anonymous UUID:                      3F7EDFE5-1AF7-40FF-B865-640187FF1877

Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Exception Type:  EXC_BAD_INSTRUCTION (SIGILL)
Exception Codes: 0x0000000000000001, 0x0000000000000000

Application Specific Information:
objc[904]: garbage collection is OFF
objc[904]: cannot form weak reference to instance (0x7f856f4a3c20) of class NSKVONotifying_PBGitHistoryController
Performing @selector(tableDoubleClick:) from sender NSTableView 0x7f856b473f60

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libobjc.A.dylib                 0x00007fff94f74768 _objc_trap + 4
1   libobjc.A.dylib                 0x00007fff94f748aa _objc_fatal + 195
2   libobjc.A.dylib                 0x00007fff94f804ad weak_register_no_lock + 346
3   libobjc.A.dylib                 0x00007fff94f80a59 objc_storeWeak + 360
4   net.phere.GitX                  0x00000001024dbdde -[PBGitHistoryController awakeFromNib] + 1534
5   com.apple.AppKit                0x00007fff93153389 -[NSIBObjectData nibInstantiateWithOwner:topLevelObjects:] + 1311
6   com.apple.AppKit                0x00007fff93272e6b -[NSNib instantiateNibWithExternalNameTable:] + 606
7   com.apple.AppKit                0x00007fff93272bd8 -[NSNib instantiateNibWithOwner:topLevelObjects:] + 251
8   com.apple.AppKit                0x00007fff9327211f -[NSViewController loadView] + 186
9   com.apple.AppKit                0x00007fff9326ddfe -[NSViewController view] + 41
10  net.phere.GitX                  0x00000001024e60a4 -[PBGitWindowController changeContentController:] + 146
11  net.phere.GitX                  0x00000001024e4164 -[PBGitSidebarController outlineViewSelectionDidChange:] + 355
12  com.apple.Foundation            0x00007fff8e099d0e __-[NSNotificationCenter addObserver:selector:name:object:]_block_invoke_1 + 47
13  com.apple.CoreFoundation        0x00007fff961ad7ba _CFXNotificationPost + 2634
14  com.apple.Foundation            0x00007fff8e085fc3 -[NSNotificationCenter postNotificationName:object:userInfo:] + 65
15  com.apple.AppKit                0x00007fff932ab049 -[NSTableView _sendSelectionChangedNotificationForRows:columns:] + 203
16  com.apple.AppKit                0x00007fff93281b0a -[NSTableView _enableSelectionPostingAndPost] + 425
17  com.apple.AppKit                0x00007fff932a9eb5 -[NSTableView _doSelectIndexes:byExtendingSelection:indexType:funnelThroughSingleIndexVersion:] + 2915
18  net.phere.GitX                  0x00000001024e391a -[PBGitSidebarController selectCurrentBranch] + 257
19  net.phere.GitX                  0x00000001024e3400 -[PBGitSidebarController observeValueForKeyPath:ofObject:change:context:] + 164
20  com.apple.Foundation            0x00007fff8e0cc78e NSKeyValueNotifyObserver + 387
21  com.apple.Foundation            0x00007fff8e0ed8c7 NSKeyValueDidChange + 486
22  com.apple.Foundation            0x00007fff8e09a027 -[NSObject(NSKeyValueObserverNotification) didChangeValueForKey:] + 130
23  net.phere.GitX                  0x00000001024fcaf4 -[PBGitRepository readCurrentBranch] + 88
24  net.phere.GitX                  0x00000001024e3972 -[PBGitSidebarController selectCurrentBranch] + 345
25  net.phere.GitX                  0x00000001024e3107 -[PBGitSidebarController awakeFromNib] + 583
26  com.apple.AppKit                0x00007fff93153389 -[NSIBObjectData nibInstantiateWithOwner:topLevelObjects:] + 1311
27  com.apple.AppKit                0x00007fff93272e6b -[NSNib instantiateNibWithExternalNameTable:] + 606
28  com.apple.AppKit                0x00007fff93272bd8 -[NSNib instantiateNibWithOwner:topLevelObjects:] + 251
29  com.apple.AppKit                0x00007fff9327211f -[NSViewController loadView] + 186
30  com.apple.AppKit                0x00007fff9326ddfe -[NSViewController view] + 41
31  net.phere.GitX                  0x00000001024e5ccb -[PBGitWindowController awakeFromNib] + 281
32  com.apple.AppKit                0x00007fff93153389 -[NSIBObjectData nibInstantiateWithOwner:topLevelObjects:] + 1311
33  com.apple.AppKit                0x00007fff931498bb loadNib + 322
34  com.apple.AppKit                0x00007fff93148db8 +[NSBundle(NSNibLoading) _loadNibFile:nameTable:withZone:ownerBundle:] + 217
35  com.apple.AppKit                0x00007fff93148cd3 +[NSBundle(NSNibLoading) loadNibFile:externalNameTable:withZone:] + 141
36  com.apple.AppKit                0x00007fff93335858 -[NSWindowController loadWindow] + 221
37  com.apple.AppKit                0x00007fff93335613 -[NSWindowController window] + 75
38  net.phere.GitX                  0x00000001024e59be -[PBGitWindowController synchronizeWindowTitleWithDocumentName] + 131
39  com.apple.AppKit                0x00007fff93334b83 -[NSWindowController setDocument:] + 46
40  net.phere.GitX                  0x00000001024fa64c -[PBGitRepository makeWindowControllers] + 77
41  com.apple.AppKit                0x00007fff93504ab7 -[NSDocumentController _finishOpeningDocument:andShowWindows:] + 108
42  com.apple.AppKit                0x00007fff9350f323 -[NSDocumentController(NSDeprecated) openDocumentWithContentsOfURL:display:error:] + 885
43  net.phere.GitX                  0x00000001024d92a5 -[OpenRecentController tableDoubleClick:] + 104
44  com.apple.CoreFoundation        0x00007fff961f470d -[NSObject performSelector:withObject:] + 61
45  com.apple.AppKit                0x00007fff932448ca -[NSApplication sendAction:to:from:] + 139
46  com.apple.AppKit                0x00007fff932447fe -[NSControl sendAction:to:] + 88
47  com.apple.AppKit                0x00007fff932ab3e2 -[NSTableView _sendAction:to:row:column:] + 87
48  com.apple.AppKit                0x00007fff932a81a5 -[NSTableView mouseDown:] + 5875
49  com.apple.AppKit                0x00007fff9320dc98 -[NSWindow sendEvent:] + 6306
50  com.apple.AppKit                0x00007fff931a73a5 -[NSApplication sendEvent:] + 5593
51  com.apple.AppKit                0x00007fff9313da0e -[NSApplication run] + 555
52  com.apple.AppKit                0x00007fff933b9eac NSApplicationMain + 867
53  net.phere.GitX                  0x0000000102508c66 main + 33
54  net.phere.GitX                  0x00000001024d6784 start + 52

Thread 1:: Dispatch queue: com.apple.libdispatch-manager
0   libsystem_kernel.dylib          0x00007fff9543a7e6 kevent + 10
1   libdispatch.dylib               0x00007fff99863786 _dispatch_mgr_invoke + 923
2   libdispatch.dylib               0x00007fff99862316 _dispatch_mgr_thread + 54

Thread 2:
0   libsystem_kernel.dylib          0x00007fff9543a192 __workq_kernreturn + 10
1   libsystem_c.dylib               0x00007fff8ebff594 _pthread_wqthread + 758
2   libsystem_c.dylib               0x00007fff8ec00b85 start_wqthread + 13

Thread 3:
0   libsystem_kernel.dylib          0x00007fff9543a192 __workq_kernreturn + 10
1   libsystem_c.dylib               0x00007fff8ebff594 _pthread_wqthread + 758
2   libsystem_c.dylib               0x00007fff8ec00b85 start_wqthread + 13

Thread 4:
0   libsystem_kernel.dylib          0x00007fff9543a192 __workq_kernreturn + 10
1   libsystem_c.dylib               0x00007fff8ebff594 _pthread_wqthread + 758
2   libsystem_c.dylib               0x00007fff8ec00b85 start_wqthread + 13

Thread 5:

Thread 6:: WebCore: LocalStorage
0   libsystem_kernel.dylib          0x00007fff95439bca __psynch_cvwait + 10
1   libsystem_c.dylib               0x00007fff8ec01274 _pthread_cond_wait + 840
2   com.apple.JavaScriptCore        0x00007fff8fc5ca60 WTF::ThreadCondition::timedWait(WTF::Mutex&, double) + 64
3   com.apple.WebCore               0x00007fff9686ef9a WTF::MessageQueue<WebCore::LocalStorageTask>::waitForMessage() + 132
4   com.apple.WebCore               0x00007fff9686eef3 WebCore::LocalStorageThread::threadEntryPoint() + 99
5   com.apple.WebCore               0x00007fff9686ee3b WebCore::LocalStorageThread::threadEntryPointCallback(void*) + 9
6   libsystem_c.dylib               0x00007fff8ebfd8bf _pthread_start + 335
7   libsystem_c.dylib               0x00007fff8ec00b75 thread_start + 13

Thread 7:: com.apple.NSURLConnectionLoader
0   libsystem_kernel.dylib          0x00007fff9543867a mach_msg_trap + 10
1   libsystem_kernel.dylib          0x00007fff95437d71 mach_msg + 73
2   com.apple.CoreFoundation        0x00007fff9619150c __CFRunLoopServiceMachPort + 188
3   com.apple.CoreFoundation        0x00007fff96199c74 __CFRunLoopRun + 1204
4   com.apple.CoreFoundation        0x00007fff96199486 CFRunLoopRunSpecific + 230
5   com.apple.Foundation            0x00007fff8e0e8fd7 +[NSURLConnection(NSURLConnectionReallyInternal) _resourceLoadLoop:] + 335
6   com.apple.Foundation            0x00007fff8e0dd72a -[NSThread main] + 68
7   com.apple.Foundation            0x00007fff8e0dd6a2 __NSThread__main__ + 1575
8   libsystem_c.dylib               0x00007fff8ebfd8bf _pthread_start + 335
9   libsystem_c.dylib               0x00007fff8ec00b75 thread_start + 13

[flurin]

I'm hanving the same problem on Lion as well. (The report details are very similar). I get the error once I click on any view that would show a history.

[bool-dev]

Same error here, just updated. Using Lion. Related to 207, 208?

[zoodor]

@bool-dev Yeah, it does look similar, though it's complaining about a weak reference to a different class to the one in #208

[bool-dev]

@zoodor Oh, yes that's right.

[bool-dev]

Btw, the readme now states that:

GitX is a graphical client for the git version control system, written specifically for OS X Mavericks.

[zoodor]

@bool-dev good spot. Pretty sure there was nothing in the release notes though, as I was specifically looking out for something like this :-(

[rowanj]

10.7, 10.8 is still supported; but since I can't test it myself stuff like this will slip through from time to time.

Working on it now.

[rowanj]

Should be fixed in the upcoming build.

[rowanj]

Just out of curiosity, what's keeping you on Lion?

[bool-dev]

For me, it's just too many libraries/programs/apps that i might have to re install if i upgrade. Just waiting for a full week (or 2) of no development/maintenance/debugging at all, to read and upgrade :)
Thanks for the quick resolution. New build is working perfectly!

[rowanj]

Good to hear!

Sounds like you're keeping busy, happy to help.

[zoodor]

@rowanj new build is working for me too - thanks, I really appreciate you fixing this so quickly :-)
I've been putting off the hassle of upgrading and I'm due a new work machine soon, so kind of figured I'll go through the pain of getting set up on Mavericks when I get that.

[bcomnes]

Running into this as well. Reverting to 95.

@rowanj I'm stuck on mavericks because my 2008 mabook air only updates to 10.7. Apple does not allow for 10.8 on this hardware.

And sadly, I can't even run the newer gitx builds on my 32 bit macbook pro stuck in 10.6 land.

[rowanj]

@bcomnes Should be fixed on 10.7 in 0.15.1899

[bcomnes]

👍 Awesome! Working now.