Merge pull request #2 from mmusich/inclusionOf3DPixelsIntoCMSSW

address remaining stylistic comments from code review
rovere · Mar 10, 2020 · 0c1871c · 0c1871c
2 parents da2ff29 + 3413fd0
commit 0c1871c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/RecoLocalTracker/SiPixelRecHits/python/PixelCPEGeneric_cfi.py b/RecoLocalTracker/SiPixelRecHits/python/PixelCPEGeneric_cfi.py
@@ -17,5 +17,5 @@
   TruncatePixelCharge = False,
   IrradiationBiasCorrection = False, # set IBC off (needs GenErrors)
   DoCosmics = False,
-  Upgrade = cms.bool(True)           # use hard-coded CPE errors (for Upgrade)
+  Upgrade = True                     # use hard-coded CPE errors (for Upgrade)
 )
diff --git a/RecoTracker/FinalTrackSelectors/python/MergeTrackCollections_cff.py b/RecoTracker/FinalTrackSelectors/python/MergeTrackCollections_cff.py
@@ -31,7 +31,6 @@
 duplicateTrackClassifier.mva.min3DLayers = [0,0,0]
 duplicateTrackClassifier.mva.maxLostLayers = [99,99,99]
 
-
 generalTracks = DuplicateListMerger.clone()
 generalTracks.originalSource = cms.InputTag("preDuplicateMergingGeneralTracks")
 generalTracks.originalMVAVals = cms.InputTag("preDuplicateMergingGeneralTracks","MVAValues")

diff --git a/RecoTracker/SpecialSeedGenerators/python/inOutSeedsFromTrackerMuons_cfi.py b/RecoTracker/SpecialSeedGenerators/python/inOutSeedsFromTrackerMuons_cfi.py
@@ -21,4 +21,3 @@
     RefitRPCHits = cms.bool(True),
     Propagator = cms.string('SmartPropagatorAnyRKOpposite'),
 )
-
diff --git a/RecoTracker/TransientTrackingRecHit/python/TTRHBuilderWithTemplate_cfi.py b/RecoTracker/TransientTrackingRecHit/python/TTRHBuilderWithTemplate_cfi.py
@@ -9,13 +9,13 @@
 )
 
 from Configuration.Eras.Modifier_trackingPhase2PU140_cff import trackingPhase2PU140
-trackingPhase2PU140.toModify(TTRHBuilderAngleAndTemplate, Phase2StripCPE = cms.string('Phase2StripCPE'))
+trackingPhase2PU140.toModify(TTRHBuilderAngleAndTemplate, Phase2StripCPE = 'Phase2StripCPE')
 
 # uncomment these two lines to turn on Cluster Repair CPE
 from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel
-phase1Pixel.toModify(TTRHBuilderAngleAndTemplate, PixelCPE = cms.string('PixelCPEClusterRepair'))
+phase1Pixel.toModify(TTRHBuilderAngleAndTemplate, PixelCPE = 'PixelCPEClusterRepair')
 
 # uncomment these two lines to turn on Cluster Repair CPE
 from Configuration.ProcessModifiers.phase2_PixelCPEGeneric_cff import phase2_PixelCPEGeneric
-phase2_PixelCPEGeneric.toModify(TTRHBuilderAngleAndTemplate, PixelCPE = cms.string('PixelCPEGeneric'))
+phase2_PixelCPEGeneric.toModify(TTRHBuilderAngleAndTemplate, PixelCPE = 'PixelCPEGeneric')
Original file line number	Diff line number	Diff line change
Expand Up		@@ -21,4 +21,3 @@
		RefitRPCHits = cms.bool(True),
		Propagator = cms.string('SmartPropagatorAnyRKOpposite'),
		)