-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django4 #58
base: master
Are you sure you want to change the base?
Django4 #58
Conversation
@roverdotcom Can this be merged in please? |
I really need this. Please merge. |
You can use this branch directly with pip or poetry: $ poetry add git+https://github.com/blocher/django-inlinecss.git#django4 or $ pip install django-inlinecss@git+https://github.com/blocher/django-inlinecss.git@django4 |
I tried to update Django version to 4.0.6, but failed due to this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks really great to me.
It fixes the breaking change and many are looking for this.
I hope this bug fix can be released soon enough!
Do we have a people with Merge/Release abilities for this repo? Who is the maintainer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello,
We are using it, but because of legacy issues... We just cannot get rid of
it instantly, but at the same time we are having deprication policy for it.
I have tried to contact the author, no luck... The only downside - either
you will have to use forks to support newer python versions or Django
versions, or you have to stuck at old dependencies, meaning all your stack
will be outdated.
We are updating our deps constantly, therefore it is not good for us to
stuck in the past...
Note: but the package is still working, even for new codebase - you can
find a fork in the issue comments.
…On Tue, May 16, 2023, 17:08 thomasb ***@***.***> wrote:
Is this module worth forking if it's not currently being maintained?
—
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUWBFEVJFVTAEFJX3UVBL3XGN36VANCNFSM5O3RHSNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Change to run with Django 4.0+: using smart_str instead of smart_text