feat: adds ConfigTest, removes NotificationService

routegroup · Sep 26, 2023 · b4553a2 · b4553a2
1 parent 1d20e51
commit b4553a2
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 109 deletions.
diff --git a/src/DTO/Casts/TransactionDto.php b/src/DTO/Casts/TransactionDto.php
@@ -30,6 +30,8 @@
  * @property-read PaymentMethod $paymentMethod
  * @property-read PaymentMethodCode $paymentMethodCode
  * @property-read PaymentProfileDto|null $paymentProfile
+ * @property-read string|null $statusCode
+ * @property-read string|null $statusCodeDescription
  */
 class TransactionDto extends BaseDto
 {

diff --git a/src/DTO/Responses/CancelledResponseDto.php → ...otifications/CancelledNotificationDto.php b/src/DTO/Responses/CancelledResponseDto.php → ...otifications/CancelledNotificationDto.php
@@ -2,14 +2,15 @@
 
 declare(strict_types=1);
 
-namespace Routegroup\Imoje\Payment\DTO\Responses;
+namespace Routegroup\Imoje\Payment\DTO\Notifications;
 
+use Routegroup\Imoje\Payment\DTO\BaseDto;
 use Routegroup\Imoje\Payment\DTO\Casts\PaymentDto;
 
 /**
  * @property-read PaymentDto $payment
  */
-class CancelledResponseDto extends ResponseDto
+class CancelledNotificationDto extends BaseDto
 {
     protected array $casts = [
         'payment' => PaymentDto::class,

diff --git a/src/DTO/Responses/OneClickResponseDto.php → ...Notifications/OneClickNotificationDto.php b/src/DTO/Responses/OneClickResponseDto.php → ...Notifications/OneClickNotificationDto.php
@@ -2,16 +2,17 @@
 
 declare(strict_types=1);
 
-namespace Routegroup\Imoje\Payment\DTO\Responses;
+namespace Routegroup\Imoje\Payment\DTO\Notifications;
 
+use Routegroup\Imoje\Payment\DTO\BaseDto;
 use Routegroup\Imoje\Payment\DTO\Casts\PaymentDto;
 use Routegroup\Imoje\Payment\DTO\Casts\TransactionDto;
 
 /**
  * @property-read TransactionDto $transaction
  * @property-read PaymentDto $payment
  */
-class OneClickResponseDto extends ResponseDto
+class OneClickNotificationDto extends BaseDto
 {
     protected array $casts = [
         'transaction' => TransactionDto::class,

diff --git a/src/Services/NotificationService.php b/src/Services/NotificationService.php
diff --git a/tests/Lib/ApiTest.php b/tests/Lib/ApiTest.php
@@ -27,7 +27,7 @@
         ],
         fn (Api $api) => $api->createRefund(RefundRequestDto::factory()->make(), '$transaction_id$'),
         RefundResponseDto::class,
-    ],
+    ], 
     'successfully calls get profile' => [
         fn (Api $api) => [
             $api->url->createProfileIdUrl('$profile_id$') => Http::response(ProfileResponseDto::factory()->make()->toArray()),

diff --git a/tests/Lib/ConfigTest.php b/tests/Lib/ConfigTest.php
@@ -0,0 +1,15 @@
+<?php
+
+use Routegroup\Imoje\Payment\Lib\Config;
+use Routegroup\Imoje\Payment\Types\Environment;
+
+it('gets config from services.imoje', function (): void {
+    $config = app(Config::class);
+
+    expect($config)
+        ->merchantId->toEqual(config('services.imoje.merchant_id'))
+        ->serviceId->toEqual(config('services.imoje.service_id'))
+        ->serviceKey->toEqual(config('services.imoje.service_key'))
+        ->apiKey->toEqual(config('services.imoje.api_key'))
+        ->env->toEqual(Environment::from(config('services.imoje.env')));
+});
diff --git a/tests/Services/NotificationServiceTest.php b/tests/Services/NotificationServiceTest.php