Sieve editor infinite parsing loop on malformed scripts

[ScottPeterJohnson]

Prerequisites

• I have searched for duplicate or closed issues
• I can recreate the issue with all plugins disabled

Describe the issue

Consider the following malformed (simplified) Sieve script, from a user who forgot to use the "text:" prefix:

vacation :subject "" :from ""
<a href="https://test.org/">test</a>

This will cause an infinite loop due to the following line:

roundcubemail/plugins/managesieve/lib/Roundcube/rcube_sieve_script.php

Line 1309 in df057fa

if ($str[$position + 1] == '*') {

Which in the case of the next character not being a *, never advances the parsing position. A simple solution is to make the error case a few lines below also apply if the next character is not a star.

What browser(s) are you seeing the problem on?

No response

What version of PHP are you using?

v8.1

What version of Roundcube are you using?

v1.6.7

JavaScript errors

No response

PHP errors

No response

[alecpl]

Fixed.