Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String replacement error in utils/error.php #9185

Closed
rivimey opened this issue Oct 25, 2023 · 2 comments
Closed

String replacement error in utils/error.php #9185

rivimey opened this issue Oct 25, 2023 · 2 comments

Comments

@rivimey
Copy link

rivimey commented Oct 25, 2023

The code at the end of program/actions/utils/error.php attempts to interpolate $skin in a string, but does so in a single-quoted string, so it fails. The correct definition is:

program/actions/utils/error.php:137:
            . '<link rel="stylesheet" type="text/css" href="skins/' . $skin . '/common.css" />'
@alecpl
Copy link
Member

alecpl commented Oct 25, 2023

Hmmm... this code does not make a lot of sense as it assumes that common.css exists in all skins, which is not true. I'll investigate whether it makes sense to just remove this line.

@alecpl
Copy link
Member

alecpl commented Oct 29, 2023

Fixed.

@alecpl alecpl closed this as completed Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants