Add = as Operator in Puppet lexer

[alex-harvey-z3q]

The = sign had been missed apparently as a valid Puppet operator.
Fixes #979.

[dblessing]

Thanks for the PR @alexharv074. Couple of comments.

[alex-harvey-z3q]

@dblessing , I refactored to avoid the confusing syntax as you suggested. Meanwhile, I left the Rspec tests in. I think they assist any future maintainers to get their heads around why a 2013-era syntax highlighter actually works on the latest version of Puppet?

[dblessing]

@gfx @jneen Do you have an opinion on the tests? We have some similar tests in the code-base but I recall @jneen telling me once that they aren't needed like this.

[dblessing]

I think they assist any future maintainers to get their heads around why a 2013-era syntax highlighter actually works on the latest version of Puppet?

FWIW Rouge is constantly updated and lexers are added, updated, etc. as needed. When Rouge was created has no bearing one whether it does or doesn't support the latest version of some language.

[jneen]

I'd generally prefer adding the example to spec/samples/puppet, since I've found the usual-style tests to be quite brittle when we have to accomodate other language changes.

[alex-harvey-z3q]

@dblessing @jneen for what it's worth, I found it much easier to analyse the behaviour of the lexers using the Rspec framework than I did using the debug output from rougify so an understanding of these tests should help maintainers develop their code. But with that said, I removed the tests and added sample code in spec/visual/samples/puppet as requested. Those tests can be restored by checking out e1ad61a.

[alex-harvey-z3q]

@dblessing not sure if you're waiting on me here, but I can't find any way from my end to move this Issue out of "Changes requested" state. Let me know if there's anything else I am supposed to to?

[alex-harvey-z3q]

Any chance this could be merged now @dblessing ?

[alex-harvey-z3q]

@dblessing Looks like this was merged over 6 months ago but still my GitHub/Jekyll blog doesn't have the fix. Any idea why that might be?

[dblessing]

Make sure to update dependencies. Looks like this was released in Rouge 3.3.0. Alex Harvey <[email protected]> schrieb am Mo. 25. März 2019 um 01:58:

…

@dblessing <https://github.com/dblessing> Looks like this was merged over 6 months ago but still my GitHub/Jekyll blog doesn't have the fix. Any idea why that might be? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#980 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACSKlNqLdl6XcOqGo5SXEIrg4biPj3szks5vaHOOgaJpZM4WYqbe> .

[alex-harvey-z3q]

Yeah, I just specify latest jekyll on my side and the rest happens magically on the GitHub side. Ok, thanks for merging and releasing anyway! I'll investigate.