-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing keywords from PHP #973
Conversation
@mcfedr I'm sorry it's taken so long to get back to you on this :( This PR looks really good. Thank you especially for adding tests to the spec. Would you also be able to add a couple of examples using the new keywords to the visual sample? It's in |
aef0e8e
to
32776ff
Compare
Hi @pyrmont It has been a little while :) I've added a few more examples, and actually a couple more cases - there is still work to be done to make the samples look as good as they could but I've not got the time right now to work on it. Also rebased on master, and run the command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed two errors in the visual test app:
32776ff
to
f25374d
Compare
@mcfedr Rouge is a better library with a more up to date version of the PHP lexer (and good to fix a tokenisation bug, too!). Thanks for all your help! We currently have a two-week cadence for minor releases. As it happens, 3.6.0 went out yesterday and so if everything sticks to schedule, this should be available as part of 3.7.0 on Tuesday 23 July. |
Awesome, great to see this merged! |
No description provided.