-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust code highlighting fixes #452
Conversation
mixin :whitespace | ||
rule /\b(?:#{Rust.keywords.join('|')})\b/, Keyword | ||
mixin :has_literals | ||
|
||
|
||
rule /#!*\[/ do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should shebangs have to be at the beginning (\A
) of the file?
Hi @HarryLovesCode, could you add some code to |
Tell me if this needs to be squashed or if there are any concerns you have. |
} | ||
} | ||
|
||
println!("The program \"{}\" calculates the value {}", program, accumulator); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is far too long to be a demo now. It is not important to me that the demos compile correctly, just that they show off a little bit of the highlighting. Is there a smaller snippet you could provide here?
Hi @HarryLovesCode, I think you added your example to the wrong file - |
Most of the issues addressed by this PR have already been merged: I opened two PRs with the missing features:
|
@HarryLovesCode I'm really sorry it took so long to get this all squared away but I've just merged in the two PRs @hugopeixoto opened for the outstanding issues and they'll be part of the next release of Rouge, v3.23.0. That's actually due to come out later today/early tomorrow (depending on your time zone). Given it's been four (!) years, I don't blame you if you've moved on but wanted to keep you in the loop just in case! @hugopeixoto Thanks so much for both submitting the remaining PRs and doing the yeoman's work of actually tracking down the PRs where the changes had been subsequently added. Really appreciate it! |
Fixes incorrect highlighting of: