Fix "Already initialized constant" warnings when running

[stanhu]

This builds upon https://github.com/rumpelsepp/rugments/commit/e6bdd4eeed47670710d48f53c4b7759a35f1f348, but ensues the specs and rackup app work.

Closes #296

[rumpelsepp]

There are more load things I think: #291

[stanhu]

@rumpelsepp Thanks, I updated the pull request. There are also more load_const calls as well. I'm not sure if #291 works with rackup, though. Manually cleaning up $LOADED_FEATUES was required.

[rodrigoargumedo]

This will also need to close #290. This seems to be good. Seeking a merge on this one.

Closes #290

[stanhu]

@jneen, any thoughts?

[segiddins]

require_relative isn't available on 1.8.7

[stanhu]

Given the .travis.yml seems to test a minimum version of Ruby v1.9.3, I don't think this should be a problem.

[JoshCheek]

But why require_relative over require?

[dentarg]

Maybe the intent is more clear with require_relative

On 15 aug 2015, at 20:21, Josh Cheek [email protected] wrote:

In lib/rouge.rb:

@@ -2,6 +2,15 @@

stdlib

require 'pathname'
+require_relative 'rouge/version'
But why not just use require?

—
Reply to this email directly or view it on GitHub.

[rodrigoargumedo]

I think require_relative is okay, for now. @jneen what are your thoughts on this?

On Aug 15, 2015, at 5:56 PM, "Patrik Ragnarsson" [email protected] wrote:

In lib/rouge.rb:

@@ -2,6 +2,15 @@

stdlib

require 'pathname'
+require_relative 'rouge/version'
Maybe the intent is more clear with require_relative
…
—
Reply to this email directly or view it on GitHub.

[esmevane]

👍

[mhutter]

👍

[jacobvosmaer]

👍

[mkarbowiak]

👍

[MrMarvin]

Are there any issues with this left open? I'd like to get this merged to get the warnings in my application disappear. Look good to me 👍

[vincentwoo]

👍

[wolf99]

👍

[n1moe1n]

👍

[wvolz]

👍

[jneen]

Closing for now, and seconding the intent to not depend on require_relative.

[jneen]

This should be fixed in v1.10.0.

[stanhu]

Thanks and welcome back, @jneen! Glad to see the new release.

I already submitted an update to GitLab:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1277

[jneen]

:]