Delete buggy detection for Mosel #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The “Lexer Development” doc says:
It is important to note that self.detect? should only return true if it is
100% sure that the language is detected.
The specified function matches any file containing the words “model” or
“package” at the beginning of a line, which misfires quite a lot!
Regularly spotted with debian/changelog files on https://salsa.debian.org/
(powered by GitLab).
|
Very good catch, thank you! |
|
Thanks for the contribution @CyrilBrulebois. LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The “Lexer Development” doc says:
The specified function matches any file containing the words “model” or “package” at the beginning of a line, which misfires quite a lot!
Regularly spotted with debian/changelog files on https://salsa.debian.org/ (powered by GitLab).
In passing, http://rouge.jneen.net/ (mentioned in the About section) is unreachable.