lexer: TOML: Support more integer and floating formats #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in TOML, the decimal point must be surrounded by at least one digit on each side.
tancnle
reviewed
Jul 1, 2022
There was a problem hiding this comment.
Thank you for your contribution @ToruNiina ❤️ The PR looks good overall. I have added some suggestions for your consideration. Please let me know what you think 🙏🏼 .
tancnle
added
the
author-action
Co-authored-by: Tan Le <[email protected]>
Co-authored-by: Tan Le <[email protected]>
Co-authored-by: Tan Le <[email protected]>
Co-authored-by: Tan Le <[email protected]>
Co-authored-by: Tan Le <[email protected]>
Co-authored-by: Tan Le <[email protected]>
|
Thank you for your time and effort on the request and many helpful suggestions. I totally agree with the suggestions. I applied all the changes. |
|
Awesome work @ToruNiina 👍🏼 Let's ship it 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wrote this patch to fix #1831 .
I added hex, bin, oct integers and special floating point numbers to the rule. And I modified the existing definition of integer and floating point numbers to allow underscores.
I also added some examples of those new features to
spec/visual/samples/toml.Then I visually checked that the examples of the features I mentioned in the issue.
In the screenshot I included some invalid examples to check if those are highlighted as an error, but I didn't include them in the
spec/visual/sampleto avoid confusion.If those invalid examples are beneficial, I will add them.
Please check it when you have time.
Thanks!