Fix notation of named stages in multi-stage docker builds #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancnle
reviewed
Mar 3, 2022
There was a problem hiding this comment.
Thank you for your contribution @bartbroere ❤️. The PR looks great to me 👍🏼 I have left a tiny suggestion. Please let me know what you think 🙏🏼
tancnle
added
the
author-action
|
Thanks @bartbroere 🚢 🚀 |
razetime
pushed a commit
to razetime/rouge
that referenced
this pull request
Jun 30, 2022
…#1809) * Fix notation of named stages in multi-stage docker builds * Check for whitespace as well to mitigate "AS" appearing in image names * Add multi-stage builder pattern to sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AScan be used as a keyword to name a stage in a multi-stage Docker build, but it isn't formatted correctly yet.Before this PR:
FROM golang:1.16 AS builder
After this PR:
FROM golang:1.16 AS builder