-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YANG lexer #1458
Add YANG lexer #1458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission and I'm sorry it took a while to get to it. I've left some comments in my review. Please let me know if anything is unclear.
One additional point: could you reduce the length of the visual sample? It should be a relatively minimal example of the syntax. As it's currently written, it seems to contain large sections that are duplicative of syntax. You don't need to make sure every line is testing one and only one rule in the lexer but for maintainability reasons, it would be helpful if it contained fewer overlapping sections of code.
Please check my comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have said something about this earlier but I removed a lot of the duplication from the visual sample. Let me know if you think it all looks good to you.
Thanks! I have adjust the visual sample to an simpler example and additionally removed the long descriptions. From my point of view, everything looks good now. |
@gribok Thanks for all your work to get this done—it's finally finished! This will be part of the next release of Rouge. That's scheduled to come out on Tuesday 14 April 🎉 |
This commit adds a lexer for the YANG 1.1 modeling language.
Based on #1457, I created the lexer in ruby.
Features
true
,false
ordeprecated
with special tokentype namespace-prefix:counter64;
.namespace-prefix
will have special token.For example
namespace urn:ieee:std:802.1AX:yang:ieee802-dot1ax;
will have no special tokenrevision-date
This will close #1457.