Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin: Highlight constructor and function calls #1321

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Kotlin: Highlight constructor and function calls #1321

merged 3 commits into from
Sep 9, 2019

Conversation

lordcodes
Copy link
Contributor

@lordcodes lordcodes commented Sep 7, 2019 •
edited
Loading

Highlight function calls as Name::Function. E.g. the 'doSomething' within: val thing = doSomething(x)

Highlight constructor calls as Name::Class. E.g. the 'MyClass' within: val thing = MyClass(x)

Fixes #1051
Fixes #1052

@pyrmont

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Sep 7, 2019
@pyrmont pyrmont self-assigned this Sep 7, 2019
pyrmont
pyrmont reviewed Sep 7, 2019
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR! Some questions:

lib/rouge/lexers/kotlin.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/kotlin.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Sep 7, 2019
@lordcodes
Copy link
Contributor Author

lordcodes commented Sep 8, 2019 •
edited
Loading

@pyrmont I have addressed the comments you made for this PR.

I will make the changes we discussed in #1324 after this PR is merged, as this PR fixes and simplifies some identifier usages.

@lordcodes
Copy link
Contributor Author

@pyrmont Thanks for the change, looks good!

@pyrmont pyrmont merged commit b867764 into rouge-ruby:master Sep 9, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Sep 9, 2019
@lordcodes lordcodes deleted the kotlin-constructor-fun-calls branch September 9, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont left review comments

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kotlin: Constructor calls not highlighted Kotlin: Function calls and property accesses not highlighted
2 participants
@lordcodes @pyrmont