Allow switching between visual test themes easily

[ashmaroli]

So that one does not need to remember the correct theme names to test..

[pyrmont]

Sorry, @ashmaroli. This review might come off as overly negative. I can see you've done a lot of work here but I really don't think a custom selector is the right approach. I believe we should be aiming to keep these pages as simple and straightforward as possible.

[pyrmont]

I should have added that, despite my negativity, I do very much like the goal of this PR. Being able to switch themes easily is a good idea.

[ashmaroli]

I believe we should be aiming to keep these pages as simple and straightforward as possible.

Thank you for taking the time for reviewing this @pyrmont. I got carried away and forgot that this is not a consumer-facing page.. 😛

Nevertheless, I've pushed a minimal version.

No longer necessary

[pyrmont]

@ashmaroli This is better but honestly, when I ran the PR on my system I didn't realise it was a selection control! And I knew that it was supposed to be one! That's cool in its own way but I think will prevent people from realising that there's a control there.

For mind, a default control is best in this situation. In the PR I submitted to your branch, I stripped out all of the CSS and just left the JavaScript (I almost wanted to add in a proper form element so that JavaScript wasn't required but I relented on that—at least for this PR).

I will say that it was great to be able to switch between the themes!

[ashmaroli]

I also thought about having a navbar rendered instead of resorting to JavaScript. But that's boring! 😛

[pyrmont]

@ashmaroli Now you're talking my language :P

[pyrmont]

@ashmaroli Do you have anything else you want to add? I'll merge otherwise.

[ashmaroli]

Do you have anything else you want to add?

No. The current state is fine.
Please proceed.